/Users/mcomp/contrib/bitcoin/src/node/miner.cpp
Line | Count | Source (jump to first uncovered line) |
1 | | // Copyright (c) 2009-2010 Satoshi Nakamoto |
2 | | // Copyright (c) 2009-2022 The Bitcoin Core developers |
3 | | // Distributed under the MIT software license, see the accompanying |
4 | | // file COPYING or http://www.opensource.org/licenses/mit-license.php. |
5 | | |
6 | | #include <node/miner.h> |
7 | | |
8 | | #include <chain.h> |
9 | | #include <chainparams.h> |
10 | | #include <coins.h> |
11 | | #include <common/args.h> |
12 | | #include <consensus/amount.h> |
13 | | #include <consensus/consensus.h> |
14 | | #include <consensus/merkle.h> |
15 | | #include <consensus/tx_verify.h> |
16 | | #include <consensus/validation.h> |
17 | | #include <deploymentstatus.h> |
18 | | #include <logging.h> |
19 | | #include <policy/feerate.h> |
20 | | #include <policy/policy.h> |
21 | | #include <pow.h> |
22 | | #include <primitives/transaction.h> |
23 | | #include <util/moneystr.h> |
24 | | #include <util/time.h> |
25 | | #include <validation.h> |
26 | | |
27 | | #include <algorithm> |
28 | | #include <utility> |
29 | | |
30 | | namespace node { |
31 | | |
32 | | int64_t GetMinimumTime(const CBlockIndex* pindexPrev, const int64_t difficulty_adjustment_interval) |
33 | 1 | { |
34 | 1 | int64_t min_time{pindexPrev->GetMedianTimePast() + 1}; |
35 | | // Height of block to be mined. |
36 | 1 | const int height{pindexPrev->nHeight + 1}; |
37 | | // Account for BIP94 timewarp rule on all networks. This makes future |
38 | | // activation safer. |
39 | 1 | if (height % difficulty_adjustment_interval == 0) { |
40 | 0 | min_time = std::max<int64_t>(min_time, pindexPrev->GetBlockTime() - MAX_TIMEWARP); |
41 | 0 | } |
42 | 1 | return min_time; |
43 | 1 | } |
44 | | |
45 | | int64_t UpdateTime(CBlockHeader* pblock, const Consensus::Params& consensusParams, const CBlockIndex* pindexPrev) |
46 | 1 | { |
47 | 1 | int64_t nOldTime = pblock->nTime; |
48 | 1 | int64_t nNewTime{std::max<int64_t>(GetMinimumTime(pindexPrev, consensusParams.DifficultyAdjustmentInterval()), |
49 | 1 | TicksSinceEpoch<std::chrono::seconds>(NodeClock::now()))}; |
50 | | |
51 | 1 | if (nOldTime < nNewTime) { |
52 | 1 | pblock->nTime = nNewTime; |
53 | 1 | } |
54 | | |
55 | | // Updating time can change work required on testnet: |
56 | 1 | if (consensusParams.fPowAllowMinDifficultyBlocks) { |
57 | 1 | pblock->nBits = GetNextWorkRequired(pindexPrev, pblock, consensusParams); |
58 | 1 | } |
59 | | |
60 | 1 | return nNewTime - nOldTime; |
61 | 1 | } |
62 | | |
63 | | void RegenerateCommitments(CBlock& block, ChainstateManager& chainman) |
64 | 0 | { |
65 | 0 | CMutableTransaction tx{*block.vtx.at(0)}; |
66 | 0 | tx.vout.erase(tx.vout.begin() + GetWitnessCommitmentIndex(block)); |
67 | 0 | block.vtx.at(0) = MakeTransactionRef(tx); |
68 | |
|
69 | 0 | const CBlockIndex* prev_block = WITH_LOCK(::cs_main, return chainman.m_blockman.LookupBlockIndex(block.hashPrevBlock)); |
70 | 0 | chainman.GenerateCoinbaseCommitment(block, prev_block); |
71 | |
|
72 | 0 | block.hashMerkleRoot = BlockMerkleRoot(block); |
73 | 0 | } |
74 | | |
75 | | static BlockAssembler::Options ClampOptions(BlockAssembler::Options options) |
76 | 1 | { |
77 | 1 | Assert(options.block_reserved_weight <= MAX_BLOCK_WEIGHT); |
78 | 1 | Assert(options.block_reserved_weight >= MINIMUM_BLOCK_RESERVED_WEIGHT); |
79 | 1 | Assert(options.coinbase_output_max_additional_sigops <= MAX_BLOCK_SIGOPS_COST); |
80 | | // Limit weight to between block_reserved_weight and MAX_BLOCK_WEIGHT for sanity: |
81 | | // block_reserved_weight can safely exceed -blockmaxweight, but the rest of the block template will be empty. |
82 | 1 | options.nBlockMaxWeight = std::clamp<size_t>(options.nBlockMaxWeight, options.block_reserved_weight, MAX_BLOCK_WEIGHT); |
83 | 1 | return options; |
84 | 1 | } |
85 | | |
86 | | BlockAssembler::BlockAssembler(Chainstate& chainstate, const CTxMemPool* mempool, const Options& options) |
87 | 1 | : chainparams{chainstate.m_chainman.GetParams()}, |
88 | 1 | m_mempool{options.use_mempool ? mempool : nullptr}, |
89 | 1 | m_chainstate{chainstate}, |
90 | 1 | m_options{ClampOptions(options)} |
91 | 1 | { |
92 | 1 | } |
93 | | |
94 | | void ApplyArgsManOptions(const ArgsManager& args, BlockAssembler::Options& options) |
95 | 0 | { |
96 | | // Block resource limits |
97 | 0 | options.nBlockMaxWeight = args.GetIntArg("-blockmaxweight", options.nBlockMaxWeight); |
98 | 0 | if (const auto blockmintxfee{args.GetArg("-blockmintxfee")}) { |
99 | 0 | if (const auto parsed{ParseMoney(*blockmintxfee)}) options.blockMinFeeRate = CFeeRate{*parsed}; |
100 | 0 | } |
101 | 0 | options.print_modified_fee = args.GetBoolArg("-printpriority", options.print_modified_fee); |
102 | 0 | options.block_reserved_weight = args.GetIntArg("-blockreservedweight", options.block_reserved_weight); |
103 | 0 | } |
104 | | |
105 | | void BlockAssembler::resetBlock() |
106 | 1 | { |
107 | 1 | inBlock.clear(); |
108 | | |
109 | | // Reserve space for fixed-size block header, txs count, and coinbase tx. |
110 | 1 | nBlockWeight = m_options.block_reserved_weight; |
111 | 1 | nBlockSigOpsCost = m_options.coinbase_output_max_additional_sigops; |
112 | | |
113 | | // These counters do not include coinbase tx |
114 | 1 | nBlockTx = 0; |
115 | 1 | nFees = 0; |
116 | 1 | } |
117 | | |
118 | | std::unique_ptr<CBlockTemplate> BlockAssembler::CreateNewBlock() |
119 | 1 | { |
120 | 1 | const auto time_start{SteadyClock::now()}; |
121 | | |
122 | 1 | resetBlock(); |
123 | | |
124 | 1 | pblocktemplate.reset(new CBlockTemplate()); |
125 | 1 | CBlock* const pblock = &pblocktemplate->block; // pointer for convenience |
126 | | |
127 | | // Add dummy coinbase tx as first transaction. It is skipped by the |
128 | | // getblocktemplate RPC and mining interface consumers must not use it. |
129 | 1 | pblock->vtx.emplace_back(); |
130 | | |
131 | 1 | LOCK(::cs_main); |
132 | 1 | CBlockIndex* pindexPrev = m_chainstate.m_chain.Tip(); |
133 | 1 | assert(pindexPrev != nullptr); |
134 | 1 | nHeight = pindexPrev->nHeight + 1; |
135 | | |
136 | 1 | pblock->nVersion = m_chainstate.m_chainman.m_versionbitscache.ComputeBlockVersion(pindexPrev, chainparams.GetConsensus()); |
137 | | // -regtest only: allow overriding block.nVersion with |
138 | | // -blockversion=N to test forking scenarios |
139 | 1 | if (chainparams.MineBlocksOnDemand()) { |
140 | 1 | pblock->nVersion = gArgs.GetIntArg("-blockversion", pblock->nVersion); |
141 | 1 | } |
142 | | |
143 | 1 | pblock->nTime = TicksSinceEpoch<std::chrono::seconds>(NodeClock::now()); |
144 | 1 | m_lock_time_cutoff = pindexPrev->GetMedianTimePast(); |
145 | | |
146 | 1 | int nPackagesSelected = 0; |
147 | 1 | int nDescendantsUpdated = 0; |
148 | 1 | if (m_mempool) { |
149 | 1 | addPackageTxs(nPackagesSelected, nDescendantsUpdated); |
150 | 1 | } |
151 | | |
152 | 1 | const auto time_1{SteadyClock::now()}; |
153 | | |
154 | 1 | m_last_block_num_txs = nBlockTx; |
155 | 1 | m_last_block_weight = nBlockWeight; |
156 | | |
157 | | // Create coinbase transaction. |
158 | 1 | CMutableTransaction coinbaseTx; |
159 | 1 | coinbaseTx.vin.resize(1); |
160 | 1 | coinbaseTx.vin[0].prevout.SetNull(); |
161 | 1 | coinbaseTx.vout.resize(1); |
162 | 1 | coinbaseTx.vout[0].scriptPubKey = m_options.coinbase_output_script; |
163 | 1 | coinbaseTx.vout[0].nValue = nFees + GetBlockSubsidy(nHeight, chainparams.GetConsensus()); |
164 | 1 | coinbaseTx.vin[0].scriptSig = CScript() << nHeight << OP_0; |
165 | 1 | pblock->vtx[0] = MakeTransactionRef(std::move(coinbaseTx)); |
166 | 1 | pblocktemplate->vchCoinbaseCommitment = m_chainstate.m_chainman.GenerateCoinbaseCommitment(*pblock, pindexPrev); |
167 | | |
168 | 1 | LogPrintf("CreateNewBlock(): block weight: %u txs: %u fees: %ld sigops %d\n", GetBlockWeight(*pblock), nBlockTx, nFees, nBlockSigOpsCost); |
169 | | |
170 | | // Fill in header |
171 | 1 | pblock->hashPrevBlock = pindexPrev->GetBlockHash(); |
172 | 1 | UpdateTime(pblock, chainparams.GetConsensus(), pindexPrev); |
173 | 1 | pblock->nBits = GetNextWorkRequired(pindexPrev, pblock, chainparams.GetConsensus()); |
174 | 1 | pblock->nNonce = 0; |
175 | | |
176 | 1 | BlockValidationState state; |
177 | 1 | if (m_options.test_block_validity && !TestBlockValidity(state, chainparams, m_chainstate, *pblock, pindexPrev, |
178 | 0 | /*fCheckPOW=*/false, /*fCheckMerkleRoot=*/false)) { |
179 | 0 | throw std::runtime_error(strprintf("%s: TestBlockValidity failed: %s", __func__, state.ToString())); |
180 | 0 | } |
181 | 1 | const auto time_2{SteadyClock::now()}; |
182 | | |
183 | 1 | LogDebug(BCLog::BENCH, "CreateNewBlock() packages: %.2fms (%d packages, %d updated descendants), validity: %.2fms (total %.2fms)\n", |
184 | 1 | Ticks<MillisecondsDouble>(time_1 - time_start), nPackagesSelected, nDescendantsUpdated, |
185 | 1 | Ticks<MillisecondsDouble>(time_2 - time_1), |
186 | 1 | Ticks<MillisecondsDouble>(time_2 - time_start)); |
187 | | |
188 | 1 | return std::move(pblocktemplate); |
189 | 1 | } |
190 | | |
191 | | void BlockAssembler::onlyUnconfirmed(CTxMemPool::setEntries& testSet) |
192 | 429 | { |
193 | 1.30k | for (CTxMemPool::setEntries::iterator iit = testSet.begin(); iit != testSet.end(); ) { |
194 | | // Only test txs not already in the block |
195 | 875 | if (inBlock.count((*iit)->GetSharedTx()->GetHash())) { |
196 | 866 | testSet.erase(iit++); |
197 | 866 | } else { |
198 | 9 | iit++; |
199 | 9 | } |
200 | 875 | } |
201 | 429 | } |
202 | | |
203 | | bool BlockAssembler::TestPackage(uint64_t packageSize, int64_t packageSigOpsCost) const |
204 | 430 | { |
205 | | // TODO: switch to weight-based accounting for packages instead of vsize-based accounting. |
206 | 430 | if (nBlockWeight + WITNESS_SCALE_FACTOR * packageSize >= m_options.nBlockMaxWeight) { |
207 | 1 | return false; |
208 | 1 | } |
209 | 429 | if (nBlockSigOpsCost + packageSigOpsCost >= MAX_BLOCK_SIGOPS_COST) { |
210 | 0 | return false; |
211 | 0 | } |
212 | 429 | return true; |
213 | 429 | } |
214 | | |
215 | | // Perform transaction-level checks before adding to block: |
216 | | // - transaction finality (locktime) |
217 | | bool BlockAssembler::TestPackageTransactions(const CTxMemPool::setEntries& package) const |
218 | 429 | { |
219 | 438 | for (CTxMemPool::txiter it : package) { |
220 | 438 | if (!IsFinalTx(it->GetTx(), nHeight, m_lock_time_cutoff)) { |
221 | 0 | return false; |
222 | 0 | } |
223 | 438 | } |
224 | 429 | return true; |
225 | 429 | } |
226 | | |
227 | | void BlockAssembler::AddToBlock(CTxMemPool::txiter iter) |
228 | 438 | { |
229 | 438 | pblocktemplate->block.vtx.emplace_back(iter->GetSharedTx()); |
230 | 438 | pblocktemplate->vTxFees.push_back(iter->GetFee()); |
231 | 438 | pblocktemplate->vTxSigOpsCost.push_back(iter->GetSigOpCost()); |
232 | 438 | nBlockWeight += iter->GetTxWeight(); |
233 | 438 | ++nBlockTx; |
234 | 438 | nBlockSigOpsCost += iter->GetSigOpCost(); |
235 | 438 | nFees += iter->GetFee(); |
236 | 438 | inBlock.insert(iter->GetSharedTx()->GetHash()); |
237 | | |
238 | 438 | if (m_options.print_modified_fee) { |
239 | 0 | LogPrintf("fee rate %s txid %s\n", |
240 | 0 | CFeeRate(iter->GetModifiedFee(), iter->GetTxSize()).ToString(), |
241 | 0 | iter->GetTx().GetHash().ToString()); |
242 | 0 | } |
243 | 438 | } |
244 | | |
245 | | /** Add descendants of given transactions to mapModifiedTx with ancestor |
246 | | * state updated assuming given transactions are inBlock. Returns number |
247 | | * of updated descendants. */ |
248 | | static int UpdatePackagesForAdded(const CTxMemPool& mempool, |
249 | | const CTxMemPool::setEntries& alreadyAdded, |
250 | | indexed_modified_transaction_set& mapModifiedTx) EXCLUSIVE_LOCKS_REQUIRED(mempool.cs) |
251 | 429 | { |
252 | 429 | AssertLockHeld(mempool.cs); |
253 | | |
254 | 429 | int nDescendantsUpdated = 0; |
255 | 438 | for (CTxMemPool::txiter it : alreadyAdded) { |
256 | 438 | CTxMemPool::setEntries descendants; |
257 | 438 | mempool.CalculateDescendants(it, descendants); |
258 | | // Insert all descendants (not yet in block) into the modified set |
259 | 1.33k | for (CTxMemPool::txiter desc : descendants) { |
260 | 1.33k | if (alreadyAdded.count(desc)) { |
261 | 448 | continue; |
262 | 448 | } |
263 | 887 | ++nDescendantsUpdated; |
264 | 887 | modtxiter mit = mapModifiedTx.find(desc); |
265 | 887 | if (mit == mapModifiedTx.end()) { |
266 | 388 | CTxMemPoolModifiedEntry modEntry(desc); |
267 | 388 | mit = mapModifiedTx.insert(modEntry).first; |
268 | 388 | } |
269 | 887 | mapModifiedTx.modify(mit, update_for_parent_inclusion(it)); |
270 | 887 | } |
271 | 438 | } |
272 | 429 | return nDescendantsUpdated; |
273 | 429 | } |
274 | | |
275 | | void BlockAssembler::SortForBlock(const CTxMemPool::setEntries& package, std::vector<CTxMemPool::txiter>& sortedEntries) |
276 | 429 | { |
277 | | // Sort package by ancestor count |
278 | | // If a transaction A depends on transaction B, then A's ancestor count |
279 | | // must be greater than B's. So this is sufficient to validly order the |
280 | | // transactions for block inclusion. |
281 | 429 | sortedEntries.clear(); |
282 | 429 | sortedEntries.insert(sortedEntries.begin(), package.begin(), package.end()); |
283 | 429 | std::sort(sortedEntries.begin(), sortedEntries.end(), CompareTxIterByAncestorCount()); |
284 | 429 | } |
285 | | |
286 | | // This transaction selection algorithm orders the mempool based |
287 | | // on feerate of a transaction including all unconfirmed ancestors. |
288 | | // Since we don't remove transactions from the mempool as we select them |
289 | | // for block inclusion, we need an alternate method of updating the feerate |
290 | | // of a transaction with its not-yet-selected ancestors as we go. |
291 | | // This is accomplished by walking the in-mempool descendants of selected |
292 | | // transactions and storing a temporary modified state in mapModifiedTxs. |
293 | | // Each time through the loop, we compare the best transaction in |
294 | | // mapModifiedTxs with the next transaction in the mempool to decide what |
295 | | // transaction package to work on next. |
296 | | void BlockAssembler::addPackageTxs(int& nPackagesSelected, int& nDescendantsUpdated) |
297 | 1 | { |
298 | 1 | const auto& mempool{*Assert(m_mempool)}; |
299 | 1 | LOCK(mempool.cs); |
300 | | |
301 | | // mapModifiedTx will store sorted packages after they are modified |
302 | | // because some of their txs are already in the block |
303 | 1 | indexed_modified_transaction_set mapModifiedTx; |
304 | | // Keep track of entries that failed inclusion, to avoid duplicate work |
305 | 1 | std::set<Txid> failedTx; |
306 | | |
307 | 1 | CTxMemPool::indexed_transaction_set::index<ancestor_score>::type::iterator mi = mempool.mapTx.get<ancestor_score>().begin(); |
308 | 1 | CTxMemPool::txiter iter; |
309 | | |
310 | | // Limit the number of attempts to add transactions to the block when it is |
311 | | // close to full; this is just a simple heuristic to finish quickly if the |
312 | | // mempool has a lot of entries. |
313 | 1 | const int64_t MAX_CONSECUTIVE_FAILURES = 1000; |
314 | 1 | int64_t nConsecutiveFailed = 0; |
315 | | |
316 | 820 | while (mi != mempool.mapTx.get<ancestor_score>().end() || !mapModifiedTx.empty()) { |
317 | | // First try to find a new transaction in mapTx to evaluate. |
318 | | // |
319 | | // Skip entries in mapTx that are already in a block or are present |
320 | | // in mapModifiedTx (which implies that the mapTx ancestor state is |
321 | | // stale due to ancestor inclusion in the block) |
322 | | // Also skip transactions that we've already failed to add. This can happen if |
323 | | // we consider a transaction in mapModifiedTx and it fails: we can then |
324 | | // potentially consider it again while walking mapTx. It's currently |
325 | | // guaranteed to fail again, but as a belt-and-suspenders check we put it in |
326 | | // failedTx and avoid re-evaluation, since the re-evaluation would be using |
327 | | // cached size/sigops/fee values that are not actually correct. |
328 | | /** Return true if given transaction from mapTx has already been evaluated, |
329 | | * or if the transaction's cached data in mapTx is incorrect. */ |
330 | 819 | if (mi != mempool.mapTx.get<ancestor_score>().end()) { |
331 | 792 | auto it = mempool.mapTx.project<0>(mi); |
332 | 792 | assert(it != mempool.mapTx.end()); |
333 | 792 | if (mapModifiedTx.count(it) || inBlock.count(it->GetSharedTx()->GetHash()) || failedTx.count(it->GetSharedTx()->GetHash())) { |
334 | 389 | ++mi; |
335 | 389 | continue; |
336 | 389 | } |
337 | 792 | } |
338 | | |
339 | | // Now that mi is not stale, determine which transaction to evaluate: |
340 | | // the next entry from mapTx, or the best from mapModifiedTx? |
341 | 430 | bool fUsingModified = false; |
342 | | |
343 | 430 | modtxscoreiter modit = mapModifiedTx.get<ancestor_score>().begin(); |
344 | 430 | if (mi == mempool.mapTx.get<ancestor_score>().end()) { |
345 | | // We're out of entries in mapTx; use the entry from mapModifiedTx |
346 | 27 | iter = modit->iter; |
347 | 27 | fUsingModified = true; |
348 | 403 | } else { |
349 | | // Try to compare the mapTx entry to the mapModifiedTx entry |
350 | 403 | iter = mempool.mapTx.project<0>(mi); |
351 | 403 | if (modit != mapModifiedTx.get<ancestor_score>().end() && |
352 | 403 | CompareTxMemPoolEntryByAncestorFee()(*modit, CTxMemPoolModifiedEntry(iter))) { |
353 | | // The best entry in mapModifiedTx has higher score |
354 | | // than the one from mapTx. |
355 | | // Switch which transaction (package) to consider |
356 | 353 | iter = modit->iter; |
357 | 353 | fUsingModified = true; |
358 | 353 | } else { |
359 | | // Either no entry in mapModifiedTx, or it's worse than mapTx. |
360 | | // Increment mi for the next loop iteration. |
361 | 50 | ++mi; |
362 | 50 | } |
363 | 403 | } |
364 | | |
365 | | // We skip mapTx entries that are inBlock, and mapModifiedTx shouldn't |
366 | | // contain anything that is inBlock. |
367 | 430 | assert(!inBlock.count(iter->GetSharedTx()->GetHash())); |
368 | | |
369 | 430 | uint64_t packageSize = iter->GetSizeWithAncestors(); |
370 | 430 | CAmount packageFees = iter->GetModFeesWithAncestors(); |
371 | 430 | int64_t packageSigOpsCost = iter->GetSigOpCostWithAncestors(); |
372 | 430 | if (fUsingModified) { |
373 | 380 | packageSize = modit->nSizeWithAncestors; |
374 | 380 | packageFees = modit->nModFeesWithAncestors; |
375 | 380 | packageSigOpsCost = modit->nSigOpCostWithAncestors; |
376 | 380 | } |
377 | | |
378 | 430 | if (packageFees < m_options.blockMinFeeRate.GetFee(packageSize)) { |
379 | | // Everything else we might consider has a lower fee rate |
380 | 0 | return; |
381 | 0 | } |
382 | | |
383 | 430 | if (!TestPackage(packageSize, packageSigOpsCost)) { |
384 | 1 | if (fUsingModified) { |
385 | | // Since we always look at the best entry in mapModifiedTx, |
386 | | // we must erase failed entries so that we can consider the |
387 | | // next best entry on the next loop iteration |
388 | 1 | mapModifiedTx.get<ancestor_score>().erase(modit); |
389 | 1 | failedTx.insert(iter->GetSharedTx()->GetHash()); |
390 | 1 | } |
391 | | |
392 | 1 | ++nConsecutiveFailed; |
393 | | |
394 | 1 | if (nConsecutiveFailed > MAX_CONSECUTIVE_FAILURES && nBlockWeight > |
395 | 0 | m_options.nBlockMaxWeight - m_options.block_reserved_weight) { |
396 | | // Give up if we're close to full and haven't succeeded in a while |
397 | 0 | break; |
398 | 0 | } |
399 | 1 | continue; |
400 | 1 | } |
401 | | |
402 | 429 | auto ancestors{mempool.AssumeCalculateMemPoolAncestors(__func__, *iter, CTxMemPool::Limits::NoLimits(), /*fSearchForParents=*/false)}; |
403 | | |
404 | 429 | onlyUnconfirmed(ancestors); |
405 | 429 | ancestors.insert(iter); |
406 | | |
407 | | // Test if all tx's are Final |
408 | 429 | if (!TestPackageTransactions(ancestors)) { |
409 | 0 | if (fUsingModified) { |
410 | 0 | mapModifiedTx.get<ancestor_score>().erase(modit); |
411 | 0 | failedTx.insert(iter->GetSharedTx()->GetHash()); |
412 | 0 | } |
413 | 0 | continue; |
414 | 0 | } |
415 | | |
416 | | // This transaction will make it in; reset the failed counter. |
417 | 429 | nConsecutiveFailed = 0; |
418 | | |
419 | | // Package can be added. Sort the entries in a valid order. |
420 | 429 | std::vector<CTxMemPool::txiter> sortedEntries; |
421 | 429 | SortForBlock(ancestors, sortedEntries); |
422 | | |
423 | 867 | for (size_t i = 0; i < sortedEntries.size(); ++i) { |
424 | 438 | AddToBlock(sortedEntries[i]); |
425 | | // Erase from the modified set, if present |
426 | 438 | mapModifiedTx.erase(sortedEntries[i]); |
427 | 438 | } |
428 | | |
429 | 429 | ++nPackagesSelected; |
430 | 429 | pblocktemplate->m_package_feerates.emplace_back(packageFees, static_cast<int32_t>(packageSize)); |
431 | | |
432 | | // Update transactions that depend on each of these |
433 | 429 | nDescendantsUpdated += UpdatePackagesForAdded(mempool, ancestors, mapModifiedTx); |
434 | 429 | } |
435 | 1 | } |
436 | | } // namespace node |