Coverage Report

Created: 2025-02-21 14:36

/root/bitcoin/src/test/util/txmempool.cpp
Line
Count
Source (jump to first uncovered line)
1
// Copyright (c) 2022 The Bitcoin Core developers
2
// Distributed under the MIT software license, see the accompanying
3
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
4
5
#include <test/util/txmempool.h>
6
7
#include <chainparams.h>
8
#include <node/context.h>
9
#include <node/mempool_args.h>
10
#include <policy/rbf.h>
11
#include <policy/truc_policy.h>
12
#include <txmempool.h>
13
#include <util/check.h>
14
#include <util/time.h>
15
#include <util/translation.h>
16
#include <validation.h>
17
18
using node::NodeContext;
19
20
CTxMemPool::Options MemPoolOptionsForTest(const NodeContext& node)
21
0
{
22
0
    CTxMemPool::Options mempool_opts{
23
        // Default to always checking mempool regardless of
24
        // chainparams.DefaultConsistencyChecks for tests
25
0
        .check_ratio = 1,
26
0
        .signals = node.validation_signals.get(),
27
0
    };
28
0
    const auto result{ApplyArgsManOptions(*node.args, ::Params(), mempool_opts)};
29
0
    Assert(result);
30
0
    return mempool_opts;
31
0
}
32
33
CTxMemPoolEntry TestMemPoolEntryHelper::FromTx(const CMutableTransaction& tx) const
34
0
{
35
0
    return FromTx(MakeTransactionRef(tx));
36
0
}
37
38
CTxMemPoolEntry TestMemPoolEntryHelper::FromTx(const CTransactionRef& tx) const
39
0
{
40
0
    return CTxMemPoolEntry{tx, nFee, TicksSinceEpoch<std::chrono::seconds>(time), nHeight, m_sequence, spendsCoinbase, sigOpCost, lp};
41
0
}
42
43
std::optional<std::string> CheckPackageMempoolAcceptResult(const Package& txns,
44
                                                           const PackageMempoolAcceptResult& result,
45
                                                           bool expect_valid,
46
                                                           const CTxMemPool* mempool)
47
0
{
48
0
    if (expect_valid) {
49
0
        if (result.m_state.IsInvalid()) {
50
0
            return strprintf("Package validation unexpectedly failed: %s", result.m_state.ToString());
51
0
        }
52
0
    } else {
53
0
        if (result.m_state.IsValid()) {
54
0
            return strprintf("Package validation unexpectedly succeeded. %s", result.m_state.ToString());
55
0
        }
56
0
    }
57
0
    if (result.m_state.GetResult() != PackageValidationResult::PCKG_POLICY && txns.size() != result.m_tx_results.size()) {
58
0
        return strprintf("txns size %u does not match tx results size %u", txns.size(), result.m_tx_results.size());
59
0
    }
60
0
    for (const auto& tx : txns) {
61
0
        const auto& wtxid = tx->GetWitnessHash();
62
0
        if (result.m_tx_results.count(wtxid) == 0) {
63
0
            return strprintf("result not found for tx %s", wtxid.ToString());
64
0
        }
65
66
0
        const auto& atmp_result = result.m_tx_results.at(wtxid);
67
0
        const bool valid{atmp_result.m_result_type == MempoolAcceptResult::ResultType::VALID};
68
0
        if (expect_valid && atmp_result.m_state.IsInvalid()) {
69
0
            return strprintf("tx %s unexpectedly failed: %s", wtxid.ToString(), atmp_result.m_state.ToString());
70
0
        }
71
72
        // Each subpackage is allowed MAX_REPLACEMENT_CANDIDATES replacements (only checking individually here)
73
0
        if (atmp_result.m_replaced_transactions.size() > MAX_REPLACEMENT_CANDIDATES) {
74
0
            return strprintf("tx %s result replaced too many transactions",
75
0
                                wtxid.ToString());
76
0
        }
77
78
        // Replacements can't happen for subpackages larger than 2
79
0
        if (!atmp_result.m_replaced_transactions.empty() &&
80
0
            atmp_result.m_wtxids_fee_calculations.has_value() && atmp_result.m_wtxids_fee_calculations.value().size() > 2) {
81
0
             return strprintf("tx %s was part of a too-large package RBF subpackage",
82
0
                                wtxid.ToString());
83
0
        }
84
85
0
        if (!atmp_result.m_replaced_transactions.empty() && mempool) {
86
0
            LOCK(mempool->cs);
87
            // If replacements occurred and it used 2 transactions, this is a package RBF and should result in a cluster of size 2
88
0
            if (atmp_result.m_wtxids_fee_calculations.has_value() && atmp_result.m_wtxids_fee_calculations.value().size() == 2) {
89
0
                const auto cluster = mempool->GatherClusters({tx->GetHash()});
90
0
                if (cluster.size() != 2) return strprintf("tx %s has too many ancestors or descendants for a package rbf", wtxid.ToString());
91
0
            }
92
0
        }
93
94
        // m_vsize and m_base_fees should exist iff the result was VALID or MEMPOOL_ENTRY
95
0
        const bool mempool_entry{atmp_result.m_result_type == MempoolAcceptResult::ResultType::MEMPOOL_ENTRY};
96
0
        if (atmp_result.m_base_fees.has_value() != (valid || mempool_entry)) {
97
0
            return strprintf("tx %s result should %shave m_base_fees", wtxid.ToString(), valid || mempool_entry ? "" : "not ");
98
0
        }
99
0
        if (atmp_result.m_vsize.has_value() != (valid || mempool_entry)) {
100
0
            return strprintf("tx %s result should %shave m_vsize", wtxid.ToString(), valid || mempool_entry ? "" : "not ");
101
0
        }
102
103
        // m_other_wtxid should exist iff the result was DIFFERENT_WITNESS
104
0
        const bool diff_witness{atmp_result.m_result_type == MempoolAcceptResult::ResultType::DIFFERENT_WITNESS};
105
0
        if (atmp_result.m_other_wtxid.has_value() != diff_witness) {
106
0
            return strprintf("tx %s result should %shave m_other_wtxid", wtxid.ToString(), diff_witness ? "" : "not ");
107
0
        }
108
109
        // m_effective_feerate and m_wtxids_fee_calculations should exist iff the result was valid
110
        // or if the failure was TX_RECONSIDERABLE
111
0
        const bool valid_or_reconsiderable{atmp_result.m_result_type == MempoolAcceptResult::ResultType::VALID ||
112
0
                    atmp_result.m_state.GetResult() == TxValidationResult::TX_RECONSIDERABLE};
113
0
        if (atmp_result.m_effective_feerate.has_value() != valid_or_reconsiderable) {
114
0
            return strprintf("tx %s result should %shave m_effective_feerate",
115
0
                                    wtxid.ToString(), valid ? "" : "not ");
116
0
        }
117
0
        if (atmp_result.m_wtxids_fee_calculations.has_value() != valid_or_reconsiderable) {
118
0
            return strprintf("tx %s result should %shave m_effective_feerate",
119
0
                                    wtxid.ToString(), valid ? "" : "not ");
120
0
        }
121
122
0
        if (mempool) {
123
            // The tx by txid should be in the mempool iff the result was not INVALID.
124
0
            const bool txid_in_mempool{atmp_result.m_result_type != MempoolAcceptResult::ResultType::INVALID};
125
0
            if (mempool->exists(GenTxid::Txid(tx->GetHash())) != txid_in_mempool) {
126
0
                return strprintf("tx %s should %sbe in mempool", wtxid.ToString(), txid_in_mempool ? "" : "not ");
127
0
            }
128
            // Additionally, if the result was DIFFERENT_WITNESS, we shouldn't be able to find the tx in mempool by wtxid.
129
0
            if (tx->HasWitness() && atmp_result.m_result_type == MempoolAcceptResult::ResultType::DIFFERENT_WITNESS) {
130
0
                if (mempool->exists(GenTxid::Wtxid(wtxid))) {
131
0
                    return strprintf("wtxid %s should not be in mempool", wtxid.ToString());
132
0
                }
133
0
            }
134
0
            for (const auto& tx_ref : atmp_result.m_replaced_transactions) {
135
0
                if (mempool->exists(GenTxid::Txid(tx_ref->GetHash()))) {
136
0
                    return strprintf("tx %s should not be in mempool as it was replaced", tx_ref->GetWitnessHash().ToString());
137
0
                }
138
0
            }
139
0
        }
140
0
    }
141
0
    return std::nullopt;
142
0
}
143
144
void CheckMempoolEphemeralInvariants(const CTxMemPool& tx_pool)
145
0
{
146
0
    LOCK(tx_pool.cs);
147
0
    for (const auto& tx_info : tx_pool.infoAll()) {
148
0
        const auto& entry = *Assert(tx_pool.GetEntry(tx_info.tx->GetHash()));
149
150
0
        std::vector<uint32_t> dust_indexes = GetDust(*tx_info.tx, tx_pool.m_opts.dust_relay_feerate);
151
152
0
        Assert(dust_indexes.size() < 2);
153
154
0
        if (dust_indexes.empty()) continue;
155
156
        // Transaction must have no base fee
157
0
        Assert(entry.GetFee() == 0 && entry.GetModifiedFee() == 0);
158
159
        // Transaction has single dust; make sure it's swept or will not be mined
160
0
        const auto& children = entry.GetMemPoolChildrenConst();
161
162
        // Multiple children should never happen as non-dust-spending child
163
        // can get mined as package
164
0
        Assert(children.size() < 2);
165
166
0
        if (children.empty()) {
167
            // No children and no fees; modified fees aside won't get mined so it's fine
168
            // Happens naturally if child spend is RBF cycled away.
169
0
            continue;
170
0
        }
171
172
        // Only-child should be spending the dust
173
0
        const auto& only_child = children.begin()->get().GetTx();
174
0
        COutPoint dust_outpoint{tx_info.tx->GetHash(), dust_indexes[0]};
175
0
        Assert(std::any_of(only_child.vin.begin(), only_child.vin.end(), [&dust_outpoint](const CTxIn& txin) {
176
0
            return txin.prevout == dust_outpoint;
177
0
            }));
178
0
    }
179
0
}
180
181
void CheckMempoolTRUCInvariants(const CTxMemPool& tx_pool)
182
0
{
183
0
    LOCK(tx_pool.cs);
184
0
    for (const auto& tx_info : tx_pool.infoAll()) {
185
0
        const auto& entry = *Assert(tx_pool.GetEntry(tx_info.tx->GetHash()));
186
0
        if (tx_info.tx->version == TRUC_VERSION) {
187
            // Check that special maximum virtual size is respected
188
0
            Assert(entry.GetTxSize() <= TRUC_MAX_VSIZE);
189
190
            // Check that special TRUC ancestor/descendant limits and rules are always respected
191
0
            Assert(entry.GetCountWithDescendants() <= TRUC_DESCENDANT_LIMIT);
192
0
            Assert(entry.GetCountWithAncestors() <= TRUC_ANCESTOR_LIMIT);
193
0
            Assert(entry.GetSizeWithDescendants() <= TRUC_MAX_VSIZE + TRUC_CHILD_MAX_VSIZE);
194
0
            Assert(entry.GetSizeWithAncestors() <= TRUC_MAX_VSIZE + TRUC_CHILD_MAX_VSIZE);
195
196
            // If this transaction has at least 1 ancestor, it's a "child" and has restricted weight.
197
0
            if (entry.GetCountWithAncestors() > 1) {
198
0
                Assert(entry.GetTxSize() <= TRUC_CHILD_MAX_VSIZE);
199
                // All TRUC transactions must only have TRUC unconfirmed parents.
200
0
                const auto& parents = entry.GetMemPoolParentsConst();
201
0
                Assert(parents.begin()->get().GetSharedTx()->version == TRUC_VERSION);
202
0
            }
203
0
        } else if (entry.GetCountWithAncestors() > 1) {
204
            // All non-TRUC transactions must only have non-TRUC unconfirmed parents.
205
0
            for (const auto& parent : entry.GetMemPoolParentsConst()) {
206
0
                Assert(parent.get().GetSharedTx()->version != TRUC_VERSION);
207
0
            }
208
0
        }
209
0
    }
210
0
}
211
212
void AddToMempool(CTxMemPool& tx_pool, const CTxMemPoolEntry& entry)
213
0
{
214
0
    LOCK2(cs_main, tx_pool.cs);
215
0
    auto changeset = tx_pool.GetChangeSet();
216
0
    changeset->StageAddition(entry.GetSharedTx(), entry.GetFee(),
217
0
            entry.GetTime().count(), entry.GetHeight(), entry.GetSequence(),
218
0
            entry.GetSpendsCoinbase(), entry.GetSigOpCost(), entry.GetLockPoints());
219
0
    changeset->Apply();
220
0
}